Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use unique tmp location for each AudioCache #1724

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Dec 7, 2023

Description

There are conflicts on writing to the same location of the temporary file path, when loading assets. This should be differentiated anyways as two individual AudioCaches should not share the same cache location.

Closes #1424

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1424

@Gustl22 Gustl22 marked this pull request as ready for review January 19, 2024 07:48
@Gustl22 Gustl22 requested a review from spydon January 19, 2024 07:52
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Gustl22 Gustl22 merged commit 2333cb7 into main Jan 19, 2024
7 checks passed
@Gustl22 Gustl22 deleted the gustl22/1424-windows-process branch January 19, 2024 11:22
nikitatg pushed a commit to nikitatg/audioplayers that referenced this pull request Apr 17, 2024
# Description

There are conflicts on writing to the same location of the temporary
file path, when loading assets. This should be differentiated anyways as
two individual AudioCaches should not share the same cache location.

Closes bluefireteam#1424
nikitatg pushed a commit to nikitatg/audioplayers that referenced this pull request Jul 19, 2024
# Description

There are conflicts on writing to the same location of the temporary
file path, when loading assets. This should be differentiated anyways as
two individual AudioCaches should not share the same cache location.

Closes bluefireteam#1424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS Error: The process cannot access the file because it is being used by another process. , errno = 32
2 participants