Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [BUG] 'PointerEvent' can't be assigned to the parameter type #442

Closed
wants to merge 1 commit into from

Conversation

SDAChess
Copy link

This pull request fixes issue #441.

Migrated for the DEV channel of flutter using this article written by the Flutter team https://flutter.dev/docs/release/breaking-changes/gesture-recognizer-add-allowed-pointer

Tested the application on android x86 and arm and seems to be working just fine.

Migrated for the DEV channel of flutter using this article written by the Flutter team https://flutter.dev/docs/release/breaking-changes/gesture-recognizer-add-allowed-pointer
@SDAChess SDAChess changed the title Fix #441 Fix [BUG] 'PointerEvent' can't be assigned to the parameter type #441 Jul 12, 2021
@SDAChess SDAChess changed the title Fix [BUG] 'PointerEvent' can't be assigned to the parameter type #441 Fix [BUG] 'PointerEvent' can't be assigned to the parameter type Jul 12, 2021
@christopherfujino
Copy link

Per the doc, this change hasn't landed in Flutter stable yet.

@renancaraujo
Copy link
Member

@christopherfujino
Copy link

TIL flame officially supports beta only

@SDAChess
Copy link
Author

Dupe of https://github.com/fireslime/photo_view/pull/420/files

How come the changes isn't on master if the PR has been merged. I don't understand lol

@christopherfujino
Copy link

Dupe of https://github.com/fireslime/photo_view/pull/420/files

How come the changes isn't on master if the PR has been merged. I don't understand lol

Looks like this follow-up was a bad merge that accidentally reverted it #427

@SDAChess
Copy link
Author

@renancaraujo You can close it and apply #420 or merge it 👍

@renancaraujo
Copy link
Member

I am preparing a release that will fix this without breaking for people using stable.

@renancaraujo
Copy link
Member

Closing this in favor of #445. Thanks for the effort, that change was lost by another stable-aimed PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants