Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: skip unsupported tracks #214

Merged
merged 2 commits into from
Jan 21, 2025
Merged

client: skip unsupported tracks #214

merged 2 commits into from
Jan 21, 2025

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jan 21, 2025

by @ingalls (sorry i closed your PR by mistake)

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.09%. Comparing base (62e427b) to head (8e5e78d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
client_stream_processor_mpegts.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files          58       58           
  Lines        4180     4184    +4     
=======================================
+ Hits         3097     3100    +3     
  Misses        883      883           
- Partials      200      201    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9
Copy link
Member Author

aler9 commented Jan 21, 2025

i added tests and merged, thanks @ingalls

@aler9 aler9 merged commit b08e07e into main Jan 21, 2025
7 of 8 checks passed
@aler9 aler9 deleted the feature/unsupported-tracks branch January 21, 2025 15:18
@ingalls
Copy link
Contributor

ingalls commented Jan 21, 2025

@aler9 I deeply appreciate you getting this merged and your work on the library. It's been an absolute lifesaver in the public safety sector! If you are ever in a position to enable Github Sponsorships on the organization be sure to let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants