h264: fix crash in DTSExtractor

Check that SPS.VUI or SPS.VUI.TimingInfo are not nil
bluenviron · Jan 5, 2023 · 07ad994 · 07ad994
1 parent 7f11619
commit 07ad994
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/pkg/codecs/h264/dtsextractor.go b/pkg/codecs/h264/dtsextractor.go
@@ -236,6 +236,10 @@ func (d *DTSExtractor) extractInner(au [][]byte, pts time.Duration) (time.Durati
 		return 0, fmt.Errorf("SPS not received yet")
 	}
 
+	if d.spsp.VUI == nil || d.spsp.VUI.TimingInfo == nil {
+		return pts, nil
+	}
+
 	pocDiff, err := d.findPOCDiff(idrPresent, au)
 	if err != nil {
 		return 0, err

diff --git a/pkg/codecs/h264/dtsextractor_test.go b/pkg/codecs/h264/dtsextractor_test.go
@@ -279,6 +279,27 @@ func TestDTSExtractor(t *testing.T) {
 				},
 			},
 		},
+		{
+			"no timing info",
+			[]sequenceSample{
+				{
+					[][]byte{
+						{ // SPS
+							0x27, 0x64, 0x00, 0x2a, 0xac, 0x52, 0x14, 0x07,
+							0x80, 0x22, 0x7e, 0x5f, 0xfc, 0x00, 0x04, 0x00,
+							0x05, 0xa8, 0x08, 0x08, 0x0d, 0xb6, 0x15, 0xaf,
+							0x7b, 0xe0, 0x20,
+						},
+						{
+							// IDR
+							byte(NALUTypeIDR),
+						},
+					},
+					1 * time.Second,
+					1 * time.Second,
+				},
+			},
+		},
 	} {
 		t.Run(ca.name, func(t *testing.T) {
 			ex := NewDTSExtractor()