Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtph264: fix decode error #150

Merged
merged 1 commit into from
Nov 14, 2022
Merged

rtph264: fix decode error #150

merged 1 commit into from
Nov 14, 2022

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Nov 14, 2022

Intact NALUs received after corrupted NALUs were wrongly discarded.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #150 (09e5010) into main (d75423d) will increase coverage by 0.03%.
The diff coverage is 90.82%.

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   82.32%   82.35%   +0.03%     
==========================================
  Files          70       70              
  Lines        7066     7062       -4     
==========================================
- Hits         5817     5816       -1     
  Misses        844      844              
+ Partials      405      402       -3     
Impacted Files Coverage Δ
pkg/rtph264/encoder.go 96.82% <ø> (ø)
serversession.go 80.13% <60.00%> (+0.05%) ⬆️
client.go 76.88% <86.66%> (+0.11%) ⬆️
clientudpl.go 82.91% <88.88%> (+0.67%) ⬆️
pkg/rtph264/decoder.go 74.50% <92.18%> (-0.70%) ⬇️
pkg/bytecounter/bytecounter.go 100.00% <100.00%> (ø)
serverconn.go 88.26% <100.00%> (-0.59%) ⬇️
serverudpl.go 87.03% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Intact NALUs received after corrupted NALUs were wrongly discarded.
@aler9 aler9 merged commit 764ac1c into main Nov 14, 2022
@aler9 aler9 deleted the rtph264 branch November 14, 2022 13:30
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants