Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: support URLs with IPv6 and no port (#313) #316

Merged
merged 1 commit into from
Jun 17, 2023
Merged

client: support URLs with IPv6 and no port (#313) #316

merged 1 commit into from
Jun 17, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jun 17, 2023

Fixes #313

@codecov-commenter
Copy link

Codecov Report

Merging #316 (fff0b8e) into main (50a4e51) will decrease coverage by 0.03%.
The diff coverage is 79.41%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   84.46%   84.43%   -0.03%     
==========================================
  Files          99       99              
  Lines       10146    10153       +7     
==========================================
+ Hits         8570     8573       +3     
- Misses       1253     1256       +3     
- Partials      323      324       +1     
Impacted Files Coverage Δ
pkg/url/url.go 89.65% <0.00%> (-6.65%) ⬇️
client.go 73.64% <90.00%> (+0.62%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 mentioned this pull request Jun 17, 2023
@aler9 aler9 merged commit 37dc292 into main Jun 17, 2023
@aler9 aler9 deleted the bug/ipv6 branch June 17, 2023 09:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw IPv6 addresses in URI are not properly supported
2 participants