Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add statistics to Client, ServerSession, ServerConn, ServerStream (#556) #656

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 14, 2024

Fixes #556

TODO:

  • per-media statistics
  • jitter buffer, localSSRC, remoteSSRC, last rtp packet sent RTP time, last rtp packet received RTP time

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 79.60199% with 164 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (8c4a3ca) to head (27dbba1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server_session.go 70.23% 38 Missing and 12 partials ⚠️
internal/rtcpreceiver/rtcpreceiver.go 14.28% 22 Missing and 2 partials ⚠️
client.go 89.41% 12 Missing and 8 partials ⚠️
server_session_media.go 86.40% 10 Missing and 4 partials ⚠️
internal/rtcpsender/rtcpsender.go 25.00% 11 Missing and 1 partial ⚠️
pkg/rtcpsender/rtcpsender.go 9.09% 10 Missing ⚠️
client_media.go 90.32% 7 Missing and 2 partials ⚠️
client_format.go 85.71% 4 Missing and 2 partials ⚠️
server_session_format.go 88.00% 4 Missing and 2 partials ⚠️
pkg/rtcpreceiver/rtcpreceiver.go 28.57% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   82.36%   82.01%   -0.35%     
==========================================
  Files         120      120              
  Lines       11888    12413     +525     
==========================================
+ Hits         9792    10181     +389     
- Misses       1709     1818     +109     
- Partials      387      414      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the feature/stats branch 6 times, most recently from aee23b1 to abe0dcb Compare December 15, 2024 22:01
@aler9 aler9 changed the title add Stats to Client, ServerSession, ServerConn, ServerStream (#556) add statistics to Client, ServerSession, ServerConn, ServerStream (#556) Dec 15, 2024
@aler9 aler9 force-pushed the feature/stats branch 3 times, most recently from 30fe08f to 6101fb5 Compare December 21, 2024 22:12
@aler9 aler9 force-pushed the feature/stats branch 13 times, most recently from 4a3cd66 to f0174cc Compare December 25, 2024 11:45
@aler9 aler9 merged commit 87c6d81 into main Dec 25, 2024
7 of 9 checks passed
@aler9 aler9 deleted the feature/stats branch December 25, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose additional stats
1 participant