Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix resetting writer when OnPlay fails #683

Merged
merged 1 commit into from
Jan 18, 2025
Merged

server: fix resetting writer when OnPlay fails #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server_session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@

if res.StatusCode != base.StatusOK {
if ss.state != ServerSessionStatePlay {
ss.writer.buffer = nil
ss.writer = nil

Check warning on line 1142 in server_session.go

View check run for this annotation

Codecov / codecov/patch

server_session.go#L1142 

Added line #L1142 was not covered by tests
}
return res, err
}
Expand Down Expand Up @@ -1238,7 +1238,7 @@
})

if res.StatusCode != base.StatusOK {
ss.writer.buffer = nil
ss.writer = nil

Check warning on line 1241 in server_session.go

View check run for this annotation

Codecov / codecov/patch

server_session.go#L1241 

Added line #L1241 was not covered by tests
return res, err
}

Expand Down