Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable VerifyMethodDigestSHA256 unless explicitly set #702

Merged
merged 1 commit into from
Feb 18, 2025
Merged

disable VerifyMethodDigestSHA256 unless explicitly set #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/auth/verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ func Verify(
nonce string,
) error {
if methods == nil {
methods = []VerifyMethod{VerifyMethodBasic, VerifyMethodDigestMD5, VerifyMethodDigestSHA256}
// disable VerifyMethodDigestSHA256 unless explicitly set
// since it prevents FFmpeg from authenticating
methods = []VerifyMethod{VerifyMethodBasic, VerifyMethodDigestMD5}
}

var auth headers.Authorization
Expand Down
2 changes: 1 addition & 1 deletion pkg/auth/verify_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func TestVerify(t *testing.T) {
req,
"myuser",
"mypass",
nil,
[]VerifyMethod{VerifyMethodBasic, VerifyMethodDigestMD5, VerifyMethodDigestSHA256},
"myrealm",
"f49ac6dd0ba708d4becddc9692d1f2ce")
require.NoError(t, err)
Expand Down
4 changes: 3 additions & 1 deletion pkg/auth/www_authenticate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import (
// GenerateWWWAuthenticate generates a WWW-Authenticate header.
func GenerateWWWAuthenticate(methods []ValidateMethod, realm string, nonce string) base.HeaderValue {
if methods == nil {
methods = []ValidateMethod{ValidateMethodBasic, ValidateMethodDigestMD5, ValidateMethodSHA256}
// disable VerifyMethodDigestSHA256 unless explicitly set
// since it prevents FFmpeg from authenticating
methods = []VerifyMethod{VerifyMethodBasic, VerifyMethodDigestMD5}
}

var ret base.HeaderValue
Expand Down