Raise maximum NALU count #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raising the maximum NAL unit count from 20 to 21 allows for streaming with recent encoders' "zerolatency" tune mode. Fixes the "unable to decode AVCC: NALU count (21) exceeds maximum allowed (20))" error messages and allows for potential sub-second latency streaming with older protocols (e.g. RTMP).
|
merged, thanks |
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 83.79% 83.79%
=======================================
Files 56 56
Lines 4826 4826
=======================================
Hits 4044 4044
Misses 570 570
Partials 212 212 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
added in MediaMTX v1.0.1 |
|
Thanks for the fast integration! 🥇 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off: Awesome work! Thanks for taking your time to create such an awesome project.
Similar to 169c5a3 here goes my humble request to raise the NAL limits a bit:
Raising the maximum NAL unit count from 20 to 21 allows for streaming with recent encoders' "zerolatency" tune mode.
Fixes the "unable to decode AVCC: NALU count (21) exceeds maximum allowed (20))" error messages and allows for potential sub-second latency streaming with older protocols (e.g. RTMP).