webrtc: fix crash during client disconnection (#1482)

OnConnectionStateChange of pion/webrtc is not thread safe. Add a mutex to make it thread safe.
bluenviron · Feb 21, 2023 · 108c9d2 · 108c9d2
1 parent 8ffdd9c
commit 108c9d2
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/internal/core/webrtc_conn.go b/internal/core/webrtc_conn.go
@@ -345,8 +345,12 @@ func (c *webRTCConn) runInner(ctx context.Context) error {
 	pcConnected := make(chan struct{})
 	pcDisconnected := make(chan struct{})
 	pcClosed := make(chan struct{})
+	var stateChangeMutex sync.Mutex
 
 	pc.OnConnectionStateChange(func(state webrtc.PeerConnectionState) {
+		stateChangeMutex.Lock()
+		defer stateChangeMutex.Unlock()
+
 		select {
 		case <-pcClosed:
 			return