Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to distinguish between rtmp and rtmps connections #1099

Closed
1 of 13 tasks
tbnguyen1407 opened this issue Aug 18, 2022 · 3 comments
Closed
1 of 13 tasks

Unable to distinguish between rtmp and rtmps connections #1099

tbnguyen1407 opened this issue Aug 18, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@tbnguyen1407
Copy link

tbnguyen1407 commented Aug 18, 2022

Which version are you using?

v0.20.0

Which operating system are you using?

  • Linux amd64 standard
  • Linux amd64 Docker
  • Linux arm64 standard
  • Linux arm64 Docker
  • Linux arm7 standard
  • Linux arm7 Docker
  • Linux arm6 standard
  • Linux arm6 Docker
  • Windows amd64 standard
  • Windows amd64 Docker (WSL backend)
  • macOS amd64 standard
  • macOS amd64 Docker
  • Other (please describe)

Describe the issue

RTMP/RTMPS readers use same type (rtmpConn), unlike RTSP/RTSPS readers which use separate types (rtspSession/rtspsSession)

GET /v1/paths/list

{
  "items": {
    "9484f126384c31f6ac9fa89d0cc96b74": {
      ...
      "readers": [
        {
          "type": "rtspsSession",
          "id": "732443073"
        },
        {
          "type": "rtspSession",
          "id": "655152465"
        },
        {
          "type": "rtmpConn",
          "id": "271786808"
        },
        {
          "type": "rtmpConn",
          "id": "699334552"
        }
      ]
    }
  }
}

Describe how to replicate the issue

  1. start the server
  2. publish/proxy with any valid stream
  3. start 2 consumers for RTMP and RTMPS
  4. call GET /v1/paths/list
  5. Observe path has 2 readers of same type

Did you attach the server logs?

no

Did you attach a network dump?

no

@aler9
Copy link
Member

aler9 commented Aug 23, 2022

This has been fixed, thanks

@aler9 aler9 added the bug Something isn't working label Aug 23, 2022
@aler9
Copy link
Member

aler9 commented Oct 25, 2022

fixed in v0.20.1

@aler9 aler9 closed this as completed Oct 25, 2022
@github-actions
Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants