Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different return result for internal HTTP API requests #1994

Closed
aler9 opened this issue Jun 27, 2023 Discussed in #1933 · 3 comments · Fixed by #1995
Closed

Different return result for internal HTTP API requests #1994

aler9 opened this issue Jun 27, 2023 Discussed in #1933 · 3 comments · Fixed by #1995
Labels
bug Something isn't working general

Comments

@aler9
Copy link
Member

aler9 commented Jun 27, 2023

Describe the feature

Discussed in #1933

Originally posted by vvitkovsky June 9, 2023
Hi gents,

I have one proposal related internal HTTP API - currently mediamtx has a bit different behavior for similar logic, e.g.:

/v2/webrtcsessions/get/{name} returns HTTP 200 (OK) with empty response if no WebRTC session with specified name was not found,
/v2/paths/get/{name} returns HTTP 404 (Not found) if such path was not found.

For my opinion it will be good if both will return HTTP 404 (Not found) because this logically more clear for a request for a non-existing resource (same for other get requests for HLS, RTSP, RTMP etc).

Best regards,
Victor

@aler9 aler9 added general bug Something isn't working labels Jun 27, 2023
aler9 added a commit that referenced this issue Jun 27, 2023
@aler9
Copy link
Member Author

aler9 commented Jun 27, 2023

Fixed by #1995

aler9 added a commit that referenced this issue Jun 27, 2023
@aler9
Copy link
Member Author

aler9 commented Jul 1, 2023

added in v0.23.7

Copy link
Contributor

github-actions bot commented Jan 3, 2024

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working general
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant