Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHEP - ETag header is E-Tag #2396

Closed
12 tasks
mfchiz opened this issue Sep 23, 2023 · 3 comments · Fixed by #2401
Closed
12 tasks

WHEP - ETag header is E-Tag #2396

mfchiz opened this issue Sep 23, 2023 · 3 comments · Fixed by #2401
Labels
bug Something isn't working webrtc

Comments

@mfchiz
Copy link

mfchiz commented Sep 23, 2023

I believe the header "E-Tag" is being used for the the WHEP handshake instead of "ETag" per the spec for WHEP.

https://www.ietf.org/id/draft-murillo-whep-02.html

Which version are you using?

v1.1.0

Which operating system are you using?

  • [ X] Linux amd64 standard
  • Linux amd64 Docker
  • Linux arm64 standard
  • Linux arm64 Docker
  • Linux arm7 standard
  • Linux arm7 Docker
  • Linux arm6 standard
  • Linux arm6 Docker
  • Windows amd64 standard
  • Windows amd64 Docker (WSL backend)
  • macOS amd64 standard
  • macOS amd64 Docker
  • Other (please describe)

Describe the issue

I created a Unity api to view WHEP sources. The code failed looking for "ETag" and it works when "E-Tag" is used. I believe the standard is "ETag"

Describe how to replicate the issue

Request a WHEP url and review the server logs and see what http headers are being returned.

Did you attach the server logs?

no

Did you attach a network dump?

no

@aler9
Copy link
Member

aler9 commented Sep 24, 2023

Fixed in v1.1.1

@jwalton
Copy link
Contributor

jwalton commented Sep 26, 2023

Note that this is a breaking change - players expecting an E-Tag will fail to find one.

Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working webrtc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants