Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp server: fix compatibility with Neko #1405

Merged
merged 1 commit into from
Jan 22, 2023
Merged

rtmp server: fix compatibility with Neko #1405

merged 1 commit into from
Jan 22, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jan 22, 2023

Fixes #1177

@codecov-commenter
Copy link

Codecov Report

Merging #1405 (3afd899) into main (97c1e68) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
+ Coverage   65.16%   65.33%   +0.16%     
==========================================
  Files         119      119              
  Lines       12889    12891       +2     
==========================================
+ Hits         8399     8422      +23     
+ Misses       3818     3794      -24     
- Partials      672      675       +3     
Impacted Files Coverage Δ
internal/rtmp/conn.go 63.64% <100.00%> (+0.09%) ⬆️
internal/core/webrtc_conn.go 54.56% <0.00%> (-0.34%) ⬇️
internal/core/hls_muxer.go 50.94% <0.00%> (-0.24%) ⬇️
internal/hls/client_processor_fmp4.go 64.88% <0.00%> (ø)
internal/core/rtmp_source.go 67.80% <0.00%> (+2.05%) ⬆️
internal/core/path.go 73.22% <0.00%> (+2.80%) ⬆️
internal/core/source_static.go 69.92% <0.00%> (+3.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit ef214b7 into main Jan 22, 2023
@aler9 aler9 deleted the neko branch January 22, 2023 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible incompatibility with rtmpsink/gstreamer with additional parameters
2 participants