Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow removing default WebRTC ICE server with environment variables #2064

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jul 16, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #2064 (51c3028) into main (8dad1e9) will increase coverage by 0.11%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
+ Coverage   62.06%   62.18%   +0.11%     
==========================================
  Files         108      108              
  Lines       11378    11381       +3     
==========================================
+ Hits         7062     7077      +15     
+ Misses       3809     3795      -14     
- Partials      507      509       +2     
Impacted Files Coverage Δ
internal/conf/env/env.go 68.75% <78.57%> (+0.75%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 1398f42 into main Jul 16, 2023
@aler9 aler9 deleted the bug/ice-env branch July 16, 2023 22:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant