Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: return 404 when a path configuration is not found (#2067) #2074

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jul 18, 2023

this involves /v2/config/paths/edit and /v2/config/paths/remove

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@22b120e). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2074   +/-   ##
=======================================
  Coverage        ?   62.22%           
=======================================
  Files           ?      109           
  Lines           ?    11380           
  Branches        ?        0           
=======================================
  Hits            ?     7081           
  Misses          ?     3789           
  Partials        ?      510           
Impacted Files Coverage Δ
internal/core/api.go 62.70% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

this involves /v2/config/paths/edit and /v2/config/paths/remove
@aler9 aler9 merged commit f7a30e7 into main Jul 18, 2023
@aler9 aler9 deleted the bug/api-404 branch July 18, 2023 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant