-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SRT encryption passphrases on configured paths #2385
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2385 +/- ##
==========================================
- Coverage 61.59% 61.58% -0.01%
==========================================
Files 129 129
Lines 14440 14476 +36
==========================================
+ Hits 8894 8915 +21
- Misses 4875 4887 +12
- Partials 671 674 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hello, this is a useful feature but this PR needs a couple of improvements:
thanks |
Thank you for the feedback. Making changes to fix those items. |
Updates made based on feedback and lint output. I was trying manually run the lint workflow, but then discovered that it runs when I pushed to main on my fork. lint.yml should be unchanged. |
Added unit tests for CheckSrtPassphrase. Use safeConf to prevent race conditions. |
79c49c2
to
b116f65
Compare
50e27a1
to
4325dc7
Compare
i added some improvements:
and merged. Thanks! |
Add support for SRT encryption passphrases on configured MediaMTX paths.
SRT supports encryption to protect payload data. SRT Passphrases must be strings between 10 and 79 characters long. Setting a SRT passphrase means that a publisher or reader using SRT MUST use the passphrase to publish or read.
Note that setting SRT passphrases does not prevent unencrypted reading from the path using another protocol!