fix(webrtc): expose ice servers on cors requests #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the link header was getting ignored by browser fetch as it was not exposed by Access-Control-Expose-Headers
Codecov Report
@@ Coverage Diff @@
## main #2479 +/- ##
==========================================
- Coverage 61.46% 61.44% -0.03%
==========================================
Files 133 133
Lines 14896 14897 +1
==========================================
- Hits 9156 9153 -3
- Misses 5053 5056 +3
- Partials 687 688 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aler9
added a commit
to bluenviron/gortsplib
that referenced
this pull request
Oct 9, 2023
|
merged, thanks! |
|
added in v1.2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link header was getting ignored by browser fetch as it was not exposed by Access-Control-Expose-Headers
fixes #2480