fix: improve unsafe path handling #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paths containing spaces or dashes were being interpreted as separate options, since the path handling lacked double quotes. This fixes all unsafe instances of "PWD" and "HOME", along with all other unsafe paths in the scripts.
This clearly shows users that the MediaMTX container will not modify the configuration file.
|
Requesting review: @aler9 :) |
|
Hello, i tested launching scripts and Docker container from inside a folder with spaces, and i can confirm that current scripts and Docker command were unable to run properly and that this PR fixes the issue. |
|
This issue is mentioned in release v1.10.0 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you so incredibly much for creating MediaMTX! It's practically the perfect media server! I'd like to give back by fixing a few bugs and issues here. :)
fix: improve unsafe path handling:
Paths containing spaces or dashes were being interpreted as separate options, since the path handling lacked double quotes.
This fixes all unsafe instances of "PWD" and "HOME", along with all other unsafe paths in the scripts.
readme: explicitly mount the configuration as read-only:
This clearly shows users that the MediaMTX container will not modify the configuration file.