Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix race condition when checking configuration #4044

Merged
merged 2 commits into from
Dec 15, 2024
Merged

fix race condition when checking configuration #4044

merged 2 commits into from
Dec 15, 2024

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 14, 2024

No description provided.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 22.85714% with 54 lines in your changes missing coverage. Please review.

Project coverage is 55.96%. Comparing base (2d1a2da) to head (0a925ec).

Files with missing lines Patch % Lines
internal/conf/path.go 20.58% 50 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4044      +/-   ##
==========================================
- Coverage   56.07%   55.96%   -0.12%     
==========================================
  Files         193      193              
  Lines       19693    19689       -4     
==========================================
- Hits        11042    11018      -24     
- Misses       7805     7827      +22     
+ Partials      846      844       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit d641392 into main Dec 15, 2024
6 of 8 checks passed
@aler9 aler9 deleted the fix/conf-check branch December 15, 2024 11:34
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This issue is mentioned in release v1.11.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant