webrtx: fix connectivity regression (#4161) #4174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when webrtcLocalTCPAddress is filled, webrtcAdditionalHosts is not empty and webrtcIPsFromInterfaces is false, connectivity was impossible to achieve.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4174 +/- ##
=======================================
Coverage 56.47% 56.48%
=======================================
Files 202 202
Lines 20648 20648
=======================================
+ Hits 11661 11663 +2
+ Misses 8119 8117 -2
Partials 868 868 ☔ View full report in Codecov by Sentry. |
|
This issue is mentioned in release v1.11.2 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4161
when webrtcLocalTCPAddress is filled, webrtcAdditionalHosts is not empty and webrtcIPsFromInterfaces is false, connectivity was impossible to achieve.