Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #44, #45 and #66 #67

Merged
merged 9 commits into from
Mar 25, 2021
Merged

Fix #44, #45 and #66 #67

merged 9 commits into from
Mar 25, 2021

Conversation

m-simonelli
Copy link

fixes #44, #45, and #66

@m-simonelli m-simonelli requested a review from morganava March 21, 2021 11:00
@m-simonelli m-simonelli requested a review from morganava March 21, 2021 13:40
@m-simonelli
remove unnecessary logger:traces()
8e9ea0d 
make is_valid() not throw
make is_valid() take std::string_view
change copy in tego_v3_onion_service_id constructor to use
 std::string_view instead of raw pointers
better logic in is_valid()
@m-simonelli m-simonelli requested a review from morganava March 21, 2021 21:27
@m-simonelli m-simonelli merged commit 1e83d96 into blueprint-freespeech:v3-2021-beta Mar 25, 2021
@m-simonelli m-simonelli mentioned this pull request Apr 2, 2021
Closed
This was referenced Jun 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganava morganava morganava left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-simonelli @morganava