-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Reading optimization ( add custom timing for each mode ) #8
Fix: Reading optimization ( add custom timing for each mode ) #8
Conversation
5fc5716
to
a5e7b30
Compare
@patrickelectric can we bump release 1.2 after this? |
a5e7b30
to
0eee150
Compare
@patrickelectric @joaoantoniocardoso Each register readings is something like 450 us. So, with benchmark running we got this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit inclined that from is ti the best way to implement it, but as a trair. The information does not imply directly on a sleep time.
actually It seems reasonable, but do not seems so verbose. I was thinking into something like: ///but it's not possible pub struct mode_values { ; |
You could just implement a trait |
0eee150
to
9b75767
Compare
|
3dc1032
to
ab66ceb
Compare
ab66ceb
to
bf24fb7
Compare
Previous readings were reaching 90.271 ms,
with this PR, they have been reduced to 5 ms, which is what is expected from the 200 Hz mode on the sensor.
Criterion Plot:
Critetion Output: