Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: logfile zip does not extract on Windows #2969

Closed
1 task done
rotu opened this issue Oct 18, 2024 · 1 comment · Fixed by #2970
Closed
1 task done

bug: logfile zip does not extract on Windows #2969

rotu opened this issue Oct 18, 2024 · 1 comment · Fixed by #2970
Labels
bug Something isn't working triage Needs triage from developers ui User Interface feature

Comments

@rotu
Copy link
Contributor

rotu commented Oct 18, 2024

Bug description

When downloading system logs in Windows, the produced file gives repeated errors like "Error 0x80070057: The parameter is incorrect". I believe this is because the logfiles use : (colon) as a delimiter, which is disallowed on Windows.

image

Steps to reproduce

  1. Download System Logs to Windows.
  2. Right click on file and choose "Extract All"

Primary pain point(s)

No response

Additional context

No response

Prerequisites

  • I have checked to make sure that a similar request has not already been filed or fixed.
@rotu rotu added bug Something isn't working triage Needs triage from developers ui User Interface feature labels Oct 18, 2024
@rotu
Copy link
Contributor Author

rotu commented Oct 18, 2024

Users who use a tool like 7-Zip or Bandizip probably won't see this error - these tools translate the filename to a legal windows filename, replacing : with _. But I would get rid of the separators anyway; they don't significantly enhance readability.

rotu added a commit to rotu/BlueOS that referenced this issue Oct 18, 2024
@rotu
Change logfile name
15e3885 
1. Remove dividers - these are unnecessary and the colon causes problems (bluerobotics#2969)
2. Switch order from month,day,year to year,month,day. This ensures correct collation when sorted
@rotu rotu mentioned this issue Oct 18, 2024
Merged
patrickelectric pushed a commit that referenced this issue Oct 20, 2024
@rotu @patrickelectric
Change logfile name
c231098 
1. Remove dividers - these are unnecessary and the colon causes problems (#2969)
2. Switch order from month,day,year to year,month,day. This ensures correct collation when sorted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Needs triage from developers ui User Interface feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change logfile name rotu/BlueOS
1 participant
@rotu