Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: autopilot manager: bump memory limit to 200mb #2171

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Williangalvani
Copy link
Member

fix #2170

@Williangalvani
Copy link
Member Author

autopilotmanager idles at ~ 25mb, the unzipped manifest file is 36mb. loading the whole thing as json in memory seems to be what is causing the large memory usage.
We can either merge this or try to find a better json parser.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue in the end is having both in memory at the same time. We can let it go since it happens only once with the manifest decompression.

@patrickelectric patrickelectric merged commit d2d85cf into bluerobotics:master Oct 18, 2023
@patrickelectric
Copy link
Member

For more information:
memray-flamegraph-output.html.zip

@Williangalvani
Copy link
Member Author

possibly relevant further on
https://pythonspeed.com/articles/json-memory-streaming/

@patrickelectric
Copy link
Member

In the end the problem was with gzip and not the json, @Williangalvani you can check the flamegraph plot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autopilot Manager runs out of memory when decompressing the firmware manifest
2 participants