Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: frontend: add allowfullscreen to BRIframe #2203

Merged
merged 1 commit into from
Nov 28, 2023
Merged

core: frontend: add allowfullscreen to BRIframe #2203

merged 1 commit into from
Nov 28, 2023

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Nov 28, 2023 •
edited
Loading

fix #2045

@rafaellehmkuhl
Copy link
Member

image

rafaellehmkuhl
rafaellehmkuhl approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's working!

@Williangalvani Williangalvani merged commit e85c728 into bluerobotics:master Nov 28, 2023
5 checks passed
@Williangalvani Williangalvani deleted the allowfullscreen branch November 28, 2023 17:49
@rafaellehmkuhl rafaellehmkuhl mentioned this pull request Nov 28, 2023
Closed
@ES-Alexander ES-Alexander mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaellehmkuhl rafaellehmkuhl rafaellehmkuhl approved these changes

@patrickelectric patrickelectric Awaiting requested review from patrickelectric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Extensions cannot go full-screen
2 participants
@Williangalvani @rafaellehmkuhl