core: ArdupilotManager: fix mavlink-router tcp endpoints #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
fix_mavlink_router_tcp
branch
9 times, most recently
from
29515c9 to
eb5943a
Compare
Williangalvani
requested review from
patrickelectric and
rafaellehmkuhl
and removed request for
patrickelectric
patrickelectric
requested changes
Dec 7, 2023
| if endpoint.connection_type == EndpointType.TCPClient: | ||
| return f"--tcp-port {endpoint.argument}" |
There was a problem hiding this comment.
Wait, here you are using tcp-port as a client and in line 68 as a server.
IIRC the tcp-port receives only the port because it binds on the host computer, being a server by nature.
There was a problem hiding this comment.
good catch, it turned out that only the master endpoint was switched
Williangalvani
force-pushed
the
fix_mavlink_router_tcp
branch
2 times, most recently
from
42c0c00 to
95103a3
Compare
Williangalvani
force-pushed
the
fix_mavlink_router_tcp
branch
from
95103a3 to
af03bbd
Compare
patrickelectric
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2222
This will only affect SITL, since Navigator uses UDP.
It also doesn't really affect it, since the behavior is the same, we were just calling things via the wrong names