core: frontend: Move to use extended glMatrix library #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added forked version from gl-matrix with needed extensions for BluesOS
* Small refactor in mavlink_math just for eslint rules compliancy
* Change to use glMatrix in CompassDisplay component instead of internal math library
* Remove internal math library from utils
|
|
JoaoMario109
requested review from
Williangalvani,
patrickelectric and
joaoantoniocardoso
|
@JoaoMario109 please also add the PR for the gl-matrix with the changes if you can on this pull request body |
Williangalvani
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Lgtm!
As for waiting or not for mergint after upstreaming the changes, I'll let @patrickelectric decide that.
Testes and working as expected here.
Nice job =]
patrickelectric
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to use a custom fork from glMatrix with extended mat3.fromEuler function instead of our own math library.
Resolves #2380
PRs containing the extensions for the library submitted to glMatrix:
toji/gl-matrix#462
toji/gl-matrix#463