Refactor COMMAND_LONG code #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
requested changes
Mar 28, 2024
| } | ||
|
|
||
|
|
||
| waitForAck(command: MavCmd, timeout: number = 3): Promise<any> { |
There was a problem hiding this comment.
It would be nice to have a documentário or something explaining what is the unit of timeout
There was a problem hiding this comment.
I renamed timeout to timeout_seconds
Williangalvani
force-pushed
the
refactor_commands
branch
from
f6fb292 to
029358f
Compare
patrickelectric
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates
mavlink2rest.sendCommandLong()andmavlink2rest.waitForAck()and updates the current calibration code to use them