Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: fix configuration of config.txt #2535

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Williangalvani
Copy link
Member

this should make blueos_startup_update stop running in the first boot.

I have a following patch that adds tests of blueos_startup_update and bcm_27xx to our pre push hook tests

@joaoantoniocardoso
Copy link
Member

joaoantoniocardoso commented Apr 15, 2024

This improvement seems a bit easy to break: every time we update the startup update script, we'd have actually to check if the reboot happens, somehow.

Couldn't we import and use the startup update functions directly?

@Williangalvani
Copy link
Member Author

This improvement seems a bit easy to break: every time we update the startup update script, we'd have actually to check if the reboot happens, somehow.

Couldn't we import and use the startup update functions directly?

it wont be breakable after my tests get in, but yes, that is an interesting idea, I'll play with it

@Williangalvani
Copy link
Member Author

I think we should probably go with this minimal patch for 1.2.x and refactor the whole thing to use blueos_startup_update for master

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @joaoantoniocardoso that we should have a single source of truth for the patches and avoid duplicated code.
Hopefully, this will not break for people that are doing updates.
We should raise an issue for the rework #2535 (comment) and the tests #2535 (comment).

Hopefully.. everything will go fine, @Williangalvani be free to merge after finishing your tests, and if you believe that is ok, cherry-pick to 1.2

@patrickelectric
Copy link
Member

patrickelectric commented Apr 15, 2024

issue #2538

@patrickelectric
Copy link
Member

@Williangalvani Williangalvani merged commit e4215d3 into bluerobotics:master Apr 15, 2024
7 checks passed
@Williangalvani Williangalvani deleted the boot_fix_stage_1 branch April 15, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants