frontend: VideStreamCreation: Add more RTSPs variants (UDP, TCP, HTTP) support #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add RTSPU, RTSPT and RTPSH stream types
JoaoMario109
force-pushed
the
add-custom-protocols-selection-on-stream-creation
branch
from
53e1347 to
825b36e
Compare
JoaoMario109
requested review from
patrickelectric,
Williangalvani and
joaoantoniocardoso
* Add support for setting RTSP(U, T, H) in pirate mode
JoaoMario109
force-pushed
the
add-custom-protocols-selection-on-stream-creation
branch
from
825b36e to
a45b820
Compare
| if (endpoint.startsWith('rtspu://')) return StreamType.RTSPU | ||
| if (endpoint.startsWith('rtsp://')) return StreamType.RTSP | ||
| if (endpoint.startsWith('rtspt://')) return StreamType.RTSPT | ||
| if (endpoint.startsWith('rtsph://')) return StreamType.RTSPH |
There was a problem hiding this comment.
As a future note, we can use an Object.keys(StreamType).find((this_protocol) => new Url(endpoint).protocol.toUpper()) or something like that
And maybe a switch case
patrickelectric
approved these changes
Jun 25, 2024
ES-Alexander
added
docs-minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2737
When in dev mode:
If set some pirate mode variant in dev mode but switching back to normal mode only that one will be added, and if change it will not more be available:
