versionchooser: bump dockerhub page_size to 200 #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES-Alexander
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
I confirmed this functionality works.
@Williangalvani mentioned this is preferable to dynamically fetching more pages with fewer per page because limits are around API calls, not their contents.
Only potential concerns are around
- whether too large a number would cause the fetch to fail if there aren't enough images
- this seems highly unlikely
- whether it's too much data to fetch for people on slow connections
- if they can't fetch this much metadata then they almost certainly can't fetch an actual image, so this seems like a non-issue
patrickelectric
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.