🐛 Handle middle mouse click on feed list items #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrazee
reviewed
Sep 18, 2023
hmm... we could but then we would have to ignore safari. let me draw that up. |
|
alright @pfrazee check out the new approach. |
pfrazee
reviewed
Sep 18, 2023
src/view/shell/index.web.tsx
Outdated
| @@ -16,11 +16,13 @@ import {useWebMediaQueries} from '../../lib/hooks/useWebMediaQueries' | |||
| import {BottomBarWeb} from './bottom-bar/BottomBarWeb' | |||
| import {useNavigation} from '@react-navigation/native' | |||
| import {NavigationProp} from 'lib/routes/types' | |||
| import {useAuxClick} from 'lib/hooks/useAuxClick.web' | |||
There was a problem hiding this comment.
Suggested change
| import {useAuxClick} from 'lib/hooks/useAuxClick.web' | |
| import {useAuxClick} from 'lib/hooks/useAuxClick' |
The .web extension gets automatically added by the bundler
|
...after I fix the thing I broke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #650
This is a PoC that attempts to handle middle mouse click on post feed items and opens the post in a new tab. This is default behavior when using
atags but on non-a tags, links only open in new tab on safari (which is an anomaly and will probably be patched down the road on safari too).I'd imagine the handler will have to be added on other wrappers where posts are rendered.
More details on the default web-supported handler for this event facebook/react#11571
middle-mouse-click.mov