Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Obscured Timestamp Tooltip in Notifications Page #1755

Closed
wants to merge 1 commit into from
Closed

Fix Obscured Timestamp Tooltip in Notifications Page #1755

wants to merge 1 commit into from

Conversation

liby
Copy link
Contributor

@liby liby commented Oct 26, 2023

This PR addresses an issue observed in the Notifications Page of our Bluesky Web Interface, where the timestamp tooltip was obscured when trying to view it. This behavior diminished the overall user experience, as users had trouble reading the timestamp which is crucial to understand the chronological context of the notification.

Fix: #1754

Context

The root of this problem is traced back to an inherent issue with React Native FlatList component. Upon further investigation, similar concerns have been discussed widely in the React Native community. For reference, the following are related issues:

Solution

To resolve this, the PR includes a workaround of applying a dynamic z-index to the CellRendererComponent by using index value from props.

CellRendererComponent={({children, index, style, ...props}) => {
    return (
        <View style={[style, {zIndex: -1 * index}]} index={index} {...props}>
            {children}
        </View>
    );
}}
image

This change effectively brings the tooltip to the forefront, improving its visibility and thereby enhancing the overall user experience.

@pfrazee pfrazee self-assigned this Oct 27, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Oct 31, 2023

This is because RNW applies z-index: 0 to all views (necolas/react-native-web#689) which I need to wrap my head around a little bit. I'd prefer not to go with this approach unless we have to.

@pfrazee pfrazee added the bugfix A PR that's fixing a bug label Jan 8, 2024
@liby liby closed this by deleting the head repository Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix A PR that's fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp Tooltip in Notifications Page obscured
2 participants