Use compiler-safe Reanimated get/set APIs #6391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
requested review from
pfrazee,
estrattonbailey,
mozzius and
haileyok
|
gaearon
commented
Nov 15, 2024
| })) | ||
|
|
||
| return ( | ||
| <AnimatedPressable | ||
| accessibilityRole="button" | ||
| onPressIn={e => { | ||
| 'worklet' |
There was a problem hiding this comment.
This wasn't a worklet. onPressIn/onPressOut run on JS already.
gaearon
commented
Nov 15, 2024
| if (isFairlyCloseToBottom) { | ||
| runOnUI(() => { |
There was a problem hiding this comment.
I've refactored this to run the entire parent block on the UI thread since we've learned that otherwise every .value access does a thread hop. Might as well run everything on UI.
gaearon
force-pushed
the
reanimated-value
branch
from
39058c3 to
e5a4d92
Compare
arcalinea
temporarily deployed
to
reanimated-value - social-app PR #6391
Render
Destroyed
mozzius
reviewed
Nov 17, 2024
Comment on lines
44
to
+45
| cancelAnimation(scale) | ||
| scale.value = withTiming(targetScale, {duration: 100}) | ||
| scale.set(() => withTiming(targetScale, {duration: 100})) |
There was a problem hiding this comment.
is cancelAnimation blocking? do they need to be grouped together into a single runOnUI call?
There was a problem hiding this comment.
i think it is. don't want to change this right now, i need to better understand what cancelAnimation does. we've heard we're not supposed to use it like this but i do remember some need for it. let's not touch for now?
mozzius
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually went through our codebase and fixed up all cases. I used find-all search for
useSharedValue,useDerivedValue, and.valueaccessors.Ran into a Reanimated bug with
set()functions, but it was easy to work around: software-mansion/react-native-reanimated#6613 (comment). You just have to add() =>when setting it to animations, likeset(() => withStuff()).Review without whitespace
Test Plan
Tried to find each of these components on iOS, verified common interactions work. Tried most of these Android, wouldn't expect platform differences with this API switch.
Look closely through the code:
set(withFoo())would fail. It has to beset(() => withFoo()). However,set(x)is fine.