Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore_sample: How to modify existing sample? #157

Open
Tracked by #189
prjemian opened this issue May 17, 2021 · 4 comments
Open
Tracked by #189

restore_sample: How to modify existing sample? #157

prjemian opened this issue May 17, 2021 · 4 comments
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Contributor

When the sample already exists, hkl.util.restore_sample() will raise ValueError. How to modify existing sample (if user option allows)?

Note the collections.namedtuple._replace() method.

@prjemian prjemian added this to the v1.0.0 milestone May 17, 2021
@prjemian prjemian self-assigned this May 17, 2021
prjemian added a commit that referenced this issue May 17, 2021
@prjemian
Copy link
Contributor Author

As the original comment suggests, replace the object may be the best method.

@prjemian
Copy link
Contributor Author

prjemian commented Aug 25, 2021

Need to look at the libhkl code for an interface to update, replace, or delete sample (configuration).

@prjemian
Copy link
Contributor Author

Short answer: That feature is not in the Python interface nor is it in libhkl.

@prjemian
Copy link
Contributor Author

@mrakitin : Implementation of this capability (modify existing sample) requires some refactoring of how sample (and reflections) are handled by the Python code. Long term, this information. For example, see #143, which is in the v1.1 Milestone. I suggest moving this issue to the v1.1 milestone (marked for completion by 2021-12-01, tentatively).

@prjemian prjemian modified the milestones: v1.0.0, v1.1 Aug 26, 2021
@prjemian prjemian modified the milestones: v1.2, v2.0 Nov 1, 2023
@prjemian prjemian added the hklpy2 For hklpy2 label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant