KeyError: 'energy' during restore_energy(orientation, diffractometer)

[prjemian]

@gfabbris reported was raised KeyError: 'energy' by this sequence:

orientation = run_orientation_info(cat[63])["fourc"]
restore_energy(orientation, diffractometer)

On inspection of the orientation object, the energy key is missing:

In [23]: orientation
Out[23]: 
{'energy_units': 'keV',
 'energy_offset': 0,
 'geometry_name': 'E4CV',
 'class_name': 'FourCircleDiffractometer',
 'sample_name': 'Na2IrO3',

The diffractometer was configured with fourc.energy.kind = "omitted".

[prjemian]

Should hklpy ignore the .kind? Or should the user suffer the consequences of this unplanned setting?

[prjemian]

Might be trickier than it seems to ignore the .kind setting. At this time, we put the orientation information in the primary stream, in the configuration.

hklpy/hkl/util.py

Lines 300 to 303 in c99a17d

	run_conf = run.primary.config
	for device in sorted(run_conf):
	conf = run_conf[device].read()
	if f"{device}_orientation_attrs" in conf:

[prjemian]

Maybe this means we should reconsider how to store the orientation so that the details are secure against this type of reconfiguration.

[prjemian]

Should be considered with #189.

[prjemian]

hkl.util.list_orientation_runs(cat) can take a long time for large catalogs. Add a progress bar?

[prjemian]

For now, raise an error when a key is missing.