Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX empty docstring for lint #134

Merged
merged 1 commit into from
Apr 27, 2021
Merged

FIX empty docstring for lint #134

merged 1 commit into from
Apr 27, 2021

Conversation

prjemian
Copy link
Contributor

fix #133

@prjemian prjemian added this to the v0.3.16 milestone Apr 27, 2021
@prjemian prjemian requested a review from mrakitin April 27, 2021 16:35
@prjemian prjemian self-assigned this Apr 27, 2021
@prjemian
Copy link
Contributor Author

@mrakitin This passes the lint test now. I fixed this in some other PR but that is not part of main yet.

mrakitin
mrakitin approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that. The newer black was complaining about it when I run the test in a fresh environment (for building docs for #130). The older one did not have it. It looks good, thanks for the quick fix, @prjemian!

@mrakitin mrakitin merged commit 7fdad1b into main Apr 27, 2021
@mrakitin mrakitin deleted the 133-lint branch April 27, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin approved these changes

Assignees

@prjemian prjemian

Labels
bug documentation
Projects
None yet
Milestone
v0.3.16
Development

Successfully merging this pull request may close these issues.

lint fails in hkl.util
2 participants
@prjemian @mrakitin