Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add diffractometer get_axis_constraints() method #304

Merged
merged 9 commits into from
Dec 1, 2023

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added this to the v1.1 milestone Nov 21, 2023
@prjemian prjemian self-assigned this Nov 21, 2023
@prjemian
Copy link
Contributor Author

@strempfer @mrakitin This very short PR is ready for review.

Copy link
Collaborator

@strempfer strempfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks!

@prjemian
Copy link
Contributor Author

Need to move the changes from e6e1d3b to a new branch

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward!

@prjemian
Copy link
Contributor Author

prjemian commented Dec 1, 2023

@strempfer @mrakitin Thanks for the reviews!

@prjemian prjemian merged commit 4898aef into main Dec 1, 2023
8 checks passed
@prjemian prjemian deleted the 302-get-constraints-function branch December 1, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a get_constraints(axis) function
3 participants