Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move on from py37 and previous #334

Merged
merged 2 commits into from
May 10, 2024
Merged

move on from py37 and previous #334

merged 2 commits into from
May 10, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the task label May 10, 2024
@prjemian prjemian added this to the v1.1.1 milestone May 10, 2024
@prjemian prjemian self-assigned this May 10, 2024
padraic-shafer
padraic-shafer reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@padraic-shafer padraic-shafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "tool list" change looks reasonable.

What is the context for "tmate" and its removal?

@prjemian
Copy link
Contributor Author

tmate would be used for interactive debugging within a GHA workflow. Has not been used in some years and is likely bit-rot. Should we ever want todo such things again, better to start from scratch. The nektos-act action, that runs workflows locally, is a better choice.

@mrakitin
Copy link
Member

tmate would be used for interactive debugging within a GHA workflow. Has not been used in some years and is likely bit-rot. Should we ever want todo such things again, better to start from scratch. The nektos-act action, that runs workflows locally, is a better choice.

BNL blocks tmate. It's fine to remove it.

+1 for the act - I used it for a couple of repos and it looks good.

mrakitin
mrakitin approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me!

@prjemian
Copy link
Contributor Author

@padraic-shafer , @mrakitin - Thanks!

@prjemian prjemian merged commit dfe9d1e into main May 10, 2024
8 checks passed
@prjemian prjemian deleted the 328-move-on-py37-and-previous branch May 10, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padraic-shafer padraic-shafer padraic-shafer left review comments

@mrakitin mrakitin mrakitin approved these changes

Assignees

@prjemian prjemian

Labels
task
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

Move on from pre-Py3.7 code
3 participants
@prjemian @mrakitin @padraic-shafer