Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffract.forward() example shows a position, not a list #346

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

prjemian
Copy link
Contributor

This is not a bug fix. The examples could use a short clarification which of the two methods (described in the table) will be used. The names are very similar.

@prjemian prjemian added this to the v1.1.2 milestone Jan 31, 2025
@prjemian prjemian requested review from mrakitin, padraic-shafer and a team January 31, 2025 21:03
@prjemian prjemian self-assigned this Jan 31, 2025
Copy link
Contributor

@padraic-shafer padraic-shafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarification.

@padraic-shafer padraic-shafer merged commit 4bc42df into main Jan 31, 2025
8 checks passed
@padraic-shafer padraic-shafer deleted the 343-diffract.forward-not-a-list branch January 31, 2025 21:19
@prjemian
Copy link
Contributor Author

@padraic-shafer Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG diffract.forward does not return a list
2 participants