Resolve TODO comment in DCSample class #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prjemian
commented
Jan 31, 2025
prjemian
commented
- close type annotation in DCSample class #321
| @@ -245,8 +245,7 @@ class DCSample: | |||
| (the reciprocal of the crystal) in an orthonormal system. | |||
| """ | |||
|
|
|||
| # TODO: Once py38 is dropped, re-enable the default value setting | |||
| U: List[List[float]] # = field(default_factory=list[list[float]]) | |||
| U: List[List[float]] | |||
There was a problem hiding this comment.
It wasn't clear whether you had already tried initializing the default value like this?
Suggested change
| U: List[List[float]] | |
| U: List[List[float]] = field(default_factory=lambda: [[]]) |
There was a problem hiding this comment.
I'll try that next.
There was a problem hiding this comment.
Will also apply to UB (above).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.