start the release notes #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrakitin
reviewed
Dec 19, 2020
|
Good point. I'll check. Others as well, for the notebooks.
…On Fri, Dec 18, 2020, 7:59 PM Maksim Rakitin ***@***.***> wrote:
***@***.**** commented on this pull request.
Looks good. One question about dependencies.
------------------------------
In docs/source/release_notes.rst
<#73 (comment)>:
> +v0.3.15 (2020-12-21)
+====================
+
+Breaking Changes
+----------------
+
+* Diffractometer wavelength **must** use *angstrom* units to match the
+ lattice constants. Previously, wavelength was stated to be in
+ `nm`. Instruments upgrading to this release should verify the units
+ actually in use.
+
+New Features and/or Enhancements
+--------------------------------
+
+* Diffractometer energy units can be specified. Unit conversions
+ are handled by the *pint* [#]_ package.
Did we ever include pint as a dependency?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#73 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARMUMFG552TDGVYZ2VTKWDSVQCJJANCNFSM4VBZESCA>
.
|
|
pint use in the environment.yml file now,
Should we add spec2nexus? It's only used in the example notebooks now.
…On Fri, Dec 18, 2020, 8:03 PM Pete Jemian ***@***.***> wrote:
Good point. I'll check. Others as well, for the notebooks.
On Fri, Dec 18, 2020, 7:59 PM Maksim Rakitin ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
>
> Looks good. One question about dependencies.
> ------------------------------
>
> In docs/source/release_notes.rst
> <#73 (comment)>:
>
> > +v0.3.15 (2020-12-21)
> +====================
> +
> +Breaking Changes
> +----------------
> +
> +* Diffractometer wavelength **must** use *angstrom* units to match the
> + lattice constants. Previously, wavelength was stated to be in
> + `nm`. Instruments upgrading to this release should verify the units
> + actually in use.
> +
> +New Features and/or Enhancements
> +--------------------------------
> +
> +* Diffractometer energy units can be specified. Unit conversions
> + are handled by the *pint* [#]_ package.
>
> Did we ever include pint as a dependency?
>
> —
> You are receiving this because you were assigned.
> Reply to this email directly, view it on GitHub
> <#73 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AARMUMFG552TDGVYZ2VTKWDSVQCJJANCNFSM4VBZESCA>
> .
>
|
|
Sounds good to add it too. We already have a heavy depensency of |
mrakitin
approved these changes
Dec 20, 2020
|
Thanks, @mrakitin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #71, fixes #74