Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove local patch now that upstream provides check_limits() #82

Merged
merged 6 commits into from
Jan 4, 2021

Conversation

prjemian
Copy link
Contributor

FIX #81

@prjemian prjemian added the task label Dec 26, 2020
@prjemian prjemian added this to the v0.3.16 milestone Dec 26, 2020
@prjemian prjemian requested a review from mrakitin December 26, 2020 18:18
@prjemian prjemian self-assigned this Dec 26, 2020
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a couple of minor styling suggestions, which are not blockers.

environment.yml Outdated Show resolved Hide resolved
hkl/tests/test_fourc.py Show resolved Hide resolved
hkl/tests/test_fourc.py Show resolved Hide resolved
hkl/tests/test_fourc.py Show resolved Hide resolved
@prjemian
Copy link
Contributor Author

prjemian commented Jan 4, 2021

@mrakitin : Thanks for the review. Changes applied. The protection worked (prefer human style over black).

@mrakitin mrakitin merged commit 2505299 into main Jan 4, 2021
@mrakitin mrakitin deleted the 81-fixed-upstream branch January 4, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove check_limits() function in test_fourc.py
2 participants