explain why the angles do not match #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrakitin
requested changes
Jan 4, 2021
There was a problem hiding this comment.
It seems there is an issue with the notebook (see the syntax error in https://nbviewer.jupyter.org/github/bluesky/hklpy/blob/602638df90dd729cd50fcaa7a2af8d020474dc41/examples/tst_e4cv_fourc.ipynb#Setup-the-UB-orientation-matrix-using-hklpy). Needs to be fixed before merging.
examples/tst_e4cv_fourc.ipynb
Outdated
| "ename": "SyntaxError", | ||
| "evalue": "invalid syntax (<ipython-input-11-3719be6e20be>, line 18)", | ||
| "traceback": [ | ||
| "\u001b[0;36m File \u001b[0;32m\"<ipython-input-11-3719be6e20be>\"\u001b[0;36m, line \u001b[0;32m18\u001b[0m\n\u001b[0;31m tbl = pyRestTable.Table()compute\u001b[0m\n\u001b[0m ^\u001b[0m\n\u001b[0;31mSyntaxError\u001b[0m\u001b[0;31m:\u001b[0m invalid syntax\n" |
examples/tst_e4cv_fourc.ipynb
Outdated
| @@ -443,7 +443,7 @@ | |||
| "\n", | |||
| "fourc.calc.sample.compute_UB(*refs)\n", | |||
| "\n", | |||
| "tbl = pyRestTable.Table()\n", | |||
| "tbl = pyRestTable.Table()compute \n", | |||
There was a problem hiding this comment.
Should it be
Suggested change
| "tbl = pyRestTable.Table()compute \n", | |
| "tbl = pyRestTable.Table().compute \n", |
?
mrakitin
approved these changes
Jan 5, 2021
|
@mrakitin Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #66
@ambarb Agree that this explanation is satisfactory? Paraphrasing: