Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to energy units and offset do not affect .calc.energy #93

Merged
merged 13 commits into from
Jan 7, 2021

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Jan 5, 2021

fixes #86

Changes to units or offset will only change .energy, not .calc.energy. To change .calc.energy, must set .energy.

To change energy, offset, & units, do it in this order:

  1. set units
  2. set offset
  3. set energy

@prjemian prjemian added the bug label Jan 5, 2021
@prjemian prjemian added this to the v0.3.16 milestone Jan 5, 2021
@prjemian prjemian self-assigned this Jan 5, 2021
@prjemian prjemian requested a review from mrakitin January 5, 2021 20:13
@prjemian
Copy link
Contributor Author

prjemian commented Jan 5, 2021

@mrakitin ready for review

@mrakitin
Copy link
Member

mrakitin commented Jan 6, 2021

There is a conflicting file here. Will review once it's resolved.

@prjemian
Copy link
Contributor Author

prjemian commented Jan 7, 2021

@mrakitin Merge conflict is resolved. Ready to review.

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Have a minor, non-blocking suggestion.

hkl/diffract.py Outdated Show resolved Hide resolved
@prjemian
Copy link
Contributor Author

prjemian commented Jan 7, 2021

Synchronize instructions to set the energy with #101 (comment) before merging.

@prjemian prjemian merged commit b4b6646 into main Jan 7, 2021
@prjemian prjemian deleted the 86-energy-units branch January 7, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: changed energy units, got same energy value
2 participants