BUG: Fixed fraction in ADTriggerStatus to match docs #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielballan
approved these changes
Jan 10, 2024
|
@DominicOram Would you mind rebasing to fix the merge conflict? Should be a simple one. Sorry that this sat here way too long. |
DominicOram
force-pushed
the
fix_AD_trigger_status_fraction
branch
from
e7b20ab to
82c88cd
Compare
DominicOram
force-pushed
the
fix_AD_trigger_status_fraction
branch
2 times, most recently
from
5161bcd to
9fb178f
Compare
DominicOram
force-pushed
the
fix_AD_trigger_status_fraction
branch
from
9fb178f to
1540899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the ADTriggerStatus to match the behaviour as documented in https://github.com/bluesky/bluesky/pull/1496/files
Also, added a test for this behaviour.