ENH: pass the count parameter along, as already documented. #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Jul 24, 2023
| pv, | ||
| timeout, | ||
| connection_timeout, | ||
| count, |
There was a problem hiding this comment.
I'm a bit torn, on one hand adding new positionals in the middle is a source of latent bugs, but on the other hand all of the positionals are required so any usage is fully broken (TypeError: missing parameter) rather than the subtle "all your inputs are shifted".
On net I think it is 👍🏻 , just set off alarms in my head.
tacaswell
approved these changes
Jul 24, 2023
mrakitin
approved these changes
Oct 10, 2023
|
Power-cycled the CI to check they still succeed against the latest version. |
|
Consider adding an option to the workflow to run the unit tests manually.
|
|
There was a recent fix to the tests (#1167), I hope it will help resolve the failing runs after my rebase on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lowest layer of pv.get accepts a count, which specifies how many array values to return. This count argument was not percolated all the way up the api stack, but was documented.
I require this to be able to retrieve values from a data acquisition device that can have a very large array of results, and the default value (2048) is way too small.