status: do not create thread to run callbacks if timeout is None #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguijarr
force-pushed
the
status_callback_thread
branch
2 times, most recently
from
e7651f9 to
3cd574a
Compare
|
Thank you for this, this seems sensible to me and looks correct to me. Can you add a test in |
mguijarr
force-pushed
the
status_callback_thread
branch
from
3cd574a to
61745f3
Compare
|
@tacaswell Done |
mguijarr
force-pushed
the
status_callback_thread
branch
from
61745f3 to
2778262
Compare
tacaswell
approved these changes
Mar 21, 2024
|
Thank you @mguijarr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a merge request that mitigates concern expressed here: #837 (comment) (also linked with issue #844).
I have the impression, a simple optimization is to not create a thread if it is not needed (in particular when timeout is set to
None, which seems to be most of the time).Otherwise some background about the problem
Statusobjects want to solve with the callbacks thread would be insightful.